Pass remaining_accounts to auction house properly
#1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KartikSoneji
requested review from
austbot and
danenbm
and removed request for
a team
|
@KartikSoneji feels like this could use a new test or a modification of one of the tests to trigger the issue in the pre-PR code? |
|
Fair point, I'll add a test. |
KartikSoneji
force-pushed
the
fix/auctioneer-execute-sale-account-infos
branch
from
6f111cd
to
a2caba9
Compare
KartikSoneji
force-pushed
the
fix/auctioneer-execute-sale-account-infos
branch
from
a2caba9
to
159ce1b
Compare
samuelvanderwaal
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors when the creators of the nft are not the buyer or seller of a timed auction nft.
Closes: